update and correct ood-portal-generator README.md #4740
Conversation
johrstrom
left a comment
johrstrom
left a comment
There was a problem hiding this comment.
Thank you for the contribution. I'm ready to merge this, but may have to fight through some tests (this shouldn't fail tests, they can just be flaky sometimes).
johrstrom
left a comment
johrstrom
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
| 1. [Fork the ondemand repository](https://github.com/OSC/ondemand/fork) | ||
| 1. Create your feature branch (`git checkout -b my-new-feature`) | ||
| 1. Commit your changes (`git commit -am 'Add some feature'`) | ||
| 1. Push to the branch (`git push origin my-new-feature`) | ||
| 1. Create a new Pull Request |
There was a problem hiding this comment.
Sorry! went to merge this and noticed this - seems like these steps should continue to be numbered 1 - 5.
There was a problem hiding this comment.
Hello.
In markdown ordered lists the numbers are incremented magically the numbers do not matter, using 1 makes it easier to insert an item to the list. https://www.markdownguide.org/basic-syntax/#ordered-lists
There was a problem hiding this comment.
You're right, I didn't look at the rendered file. That's so counter-intuitive!
github-project-automation
bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
3 participants
this time without changes to changelog